Skip to content

Commit 92ddfaa

Browse files
committed
Merge branch 'jk/format-person-part-buffer-limit' into maint
By Jeff King * jk/format-person-part-buffer-limit: pretty: avoid buffer overflow in format_person_part
2 parents 63cdf16 + c9b4e9e commit 92ddfaa

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

pretty.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -547,8 +547,10 @@ static size_t format_person_part(struct strbuf *sb, char part,
547547
mail_end = s.mail_end;
548548

549549
if (part == 'N' || part == 'E') { /* mailmap lookup */
550-
strlcpy(person_name, name_start, name_end - name_start + 1);
551-
strlcpy(person_mail, mail_start, mail_end - mail_start + 1);
550+
snprintf(person_name, sizeof(person_name), "%.*s",
551+
(int)(name_end - name_start), name_start);
552+
snprintf(person_mail, sizeof(person_mail), "%.*s",
553+
(int)(mail_end - mail_start), mail_start);
552554
mailmap_name(person_mail, sizeof(person_mail), person_name, sizeof(person_name));
553555
name_start = person_name;
554556
name_end = name_start + strlen(person_name);

0 commit comments

Comments
 (0)