Skip to content

Commit 92e1bbc

Browse files
committed
Merge branch 'jh/partial-clone'
The recent addition of "partial clone" experimental feature kicked in when it shouldn't, namely, when there is no partial-clone filter defined even if extensions.partialclone is set. * jh/partial-clone: list-objects: check if filter is NULL before using
2 parents 078f3dc + cac1137 commit 92e1bbc

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

list-objects-filter-options.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,8 @@ void partial_clone_get_default_filter_spec(
146146
/*
147147
* Parse default value, but silently ignore it if it is invalid.
148148
*/
149+
if (!core_partial_clone_filter_default)
150+
return;
149151
gently_parse_list_objects_filter(filter_options,
150152
core_partial_clone_filter_default,
151153
NULL);

t/t0410-partial-clone.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,15 @@ promise_and_delete () {
2323
delete_object repo "$HASH"
2424
}
2525

26+
test_expect_success 'extensions.partialclone without filter' '
27+
test_create_repo server &&
28+
git clone --filter="blob:none" "file://$(pwd)/server" client &&
29+
git -C client config --unset core.partialclonefilter &&
30+
git -C client fetch origin
31+
'
32+
2633
test_expect_success 'missing reflog object, but promised by a commit, passes fsck' '
34+
rm -rf repo &&
2735
test_create_repo repo &&
2836
test_commit -C repo my_commit &&
2937

0 commit comments

Comments
 (0)