transport-helper.c: rearrange xcalloc arguments

modocache · gitster · commit 92e25b6b5b66 · 2014-05-27T14:02:45.000-07:00
xcalloc() takes two arguments: the number of elements and their size.
transport_helper_init passes the arguments in reverse order, passing the
size of a helper_data*, followed by the number to allocate.

Rearrange them so they are in the correct order.

Signed-off-by: Brian Gesiak &lt;modocache@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/transport-helper.c b/transport-helper.c
@@ -1026,7 +1026,7 @@ static struct ref *get_refs_list(struct transport *transport, int for_push)
 
 int transport_helper_init(struct transport *transport, const char *name)
 {
-	struct helper_data *data = xcalloc(sizeof(*data), 1);
+	struct helper_data *data = xcalloc(1, sizeof(*data));
 	data->name = name;
 
 	if (getenv("GIT_TRANSPORT_HELPER_DEBUG"))

Original file line number	Diff line number	Diff line change
`@@ -1026,7 +1026,7 @@ static struct ref get_refs_list(struct transport transport, int for_push)`
`1026`	`1026`
`1027`	`1027`	`int transport_helper_init(struct transport transport, const char name)`
`1028`	`1028`	`{`
`1029`		`- struct helper_data data = xcalloc(sizeof(data), 1);`
	`1029`	`+ struct helper_data data = xcalloc(1, sizeof(data));`
`1030`	`1030`	`data->name = name;`
`1031`	`1031`
`1032`	`1032`	`if (getenv("GIT_TRANSPORT_HELPER_DEBUG"))`