Skip to content

Commit 92e6647

Browse files
rjustogitster
authored andcommitted
tag: error when git-column fails
If the user asks for the list of tags to be displayed in columns ("--columns"), a child git-column process is used to format the output as expected. In a rare situation where we encounter a problem spawning that child process, we will work erroneously. Make noticeable we're having a problem executing git-column, so the user can act accordingly. Signed-off-by: Rubén Justo <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 0d1bd1d commit 92e6647

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

builtin/tag.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,8 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
537537
struct column_options copts;
538538
memset(&copts, 0, sizeof(copts));
539539
copts.padding = 2;
540-
run_column_filter(colopts, &copts);
540+
if (run_column_filter(colopts, &copts))
541+
die(_("could not start 'git column'"));
541542
}
542543
filter.name_patterns = argv;
543544
ret = list_tags(&filter, sorting, &format);

0 commit comments

Comments
 (0)