Skip to content

Commit 93d52ed

Browse files
rybakgitster
authored andcommitted
userdiff: support Java sealed classes
A new kind of class was added in Java 17 -- sealed classes.[1] This feature includes several new keywords that may appear in a declaration of a class. New modifiers before name of the class: "sealed" and "non-sealed", and a clause after name of the class marked by keyword "permits". The current set of regular expressions in userdiff.c already allows the modifier "sealed" and the "permits" clause, but not the modifier "non-sealed", which is the first hyphenated keyword in Java.[2] Allow hyphen in the words that precede the name of type to match the "non-sealed" modifier. In new input file "java-sealed" for the test t4018-diff-funcname.sh, use a Java code comment for the marker "RIGHT". This workaround is needed, because the name of the sealed class appears on the line of code that has the "ChangeMe" marker. [1] Detailed description in "JEP 409: Sealed Classes" https://openjdk.org/jeps/409 [2] "JEP draft: Keyword Management for the Java Language" https://openjdk.org/jeps/8223002 Signed-off-by: Andrei Rybak <[email protected]> Reviewed-by: Johannes Sixt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 575e6fc commit 93d52ed

7 files changed

+40
-1
lines changed

t/t4018/java-non-sealed

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
public abstract sealed class SealedClass {
2+
public static non-sealed class RIGHT extends SealedClass {
3+
static int ONE;
4+
static int TWO;
5+
static int THREE;
6+
private int ChangeMe;
7+
}
8+
}

t/t4018/java-sealed

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
public abstract sealed class Sealed { // RIGHT
2+
static int ONE;
3+
static int TWO;
4+
static int THREE;
5+
public final class ChangeMe extends Sealed {
6+
}
7+
}

t/t4018/java-sealed-permits

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
public abstract sealed class RIGHT permits PermittedA, PermittedB {
2+
static int ONE;
3+
static int TWO;
4+
static int THREE;
5+
private int ChangeMe;
6+
}

t/t4018/java-sealed-type-parameters

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
public abstract sealed class RIGHT<A, B> {
2+
static int ONE;
3+
static int TWO;
4+
static int THREE;
5+
private int ChangeMe;
6+
}
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
public abstract sealed class RIGHT<A, B> implements List<A> permits PermittedA, PermittedB {
2+
static int ONE;
3+
static int TWO;
4+
static int THREE;
5+
private int ChangeMe;
6+
}
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
public abstract sealed class RIGHT<A, B> permits PermittedA, PermittedB {
2+
static int ONE;
3+
static int TWO;
4+
static int THREE;
5+
private int ChangeMe;
6+
}

userdiff.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ PATTERNS("html",
171171
PATTERNS("java",
172172
"!^[ \t]*(catch|do|for|if|instanceof|new|return|switch|throw|while)\n"
173173
/* Class, enum, interface, and record declarations */
174-
"^[ \t]*(([a-z]+[ \t]+)*(class|enum|interface|record)[ \t]+.*)$\n"
174+
"^[ \t]*(([a-z-]+[ \t]+)*(class|enum|interface|record)[ \t]+.*)$\n"
175175
/* Method definitions; note that constructor signatures are not */
176176
/* matched because they are indistinguishable from method calls. */
177177
"^[ \t]*(([A-Za-z_<>&][][?&<>.,A-Za-z_0-9]*[ \t]+)+[A-Za-z_][A-Za-z_0-9]*[ \t]*\\([^;]*)$",

0 commit comments

Comments
 (0)