Skip to content

Commit 95cef50

Browse files
kbleesdscho
authored andcommitted
Win32: implement basic symlink() functionality (file symlinks only)
Implement symlink() that always creates file symlinks. Fails with ENOSYS if symlinks are disabled or unsupported. Note: CreateSymbolicLinkW() was introduced with symlink support in Windows Vista. For compatibility with Windows XP, we need to load it dynamically and fail gracefully if it isnt's available. Signed-off-by: Karsten Blees <[email protected]>
1 parent f760d2d commit 95cef50

File tree

2 files changed

+29
-2
lines changed

2 files changed

+29
-2
lines changed

compat/mingw.c

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2730,6 +2730,34 @@ int link(const char *oldpath, const char *newpath)
27302730
return 0;
27312731
}
27322732

2733+
int symlink(const char *target, const char *link)
2734+
{
2735+
wchar_t wtarget[MAX_LONG_PATH], wlink[MAX_LONG_PATH];
2736+
int len;
2737+
2738+
/* fail if symlinks are disabled or API is not supported (WinXP) */
2739+
if (!has_symlinks) {
2740+
errno = ENOSYS;
2741+
return -1;
2742+
}
2743+
2744+
if ((len = xutftowcs_long_path(wtarget, target)) < 0
2745+
|| xutftowcs_long_path(wlink, link) < 0)
2746+
return -1;
2747+
2748+
/* convert target dir separators to backslashes */
2749+
while (len--)
2750+
if (wtarget[len] == '/')
2751+
wtarget[len] = '\\';
2752+
2753+
/* create file symlink */
2754+
if (!CreateSymbolicLinkW(wlink, wtarget, 0)) {
2755+
errno = err_win_to_posix(GetLastError());
2756+
return -1;
2757+
}
2758+
return 0;
2759+
}
2760+
27332761
#ifndef _WINNT_H
27342762
/*
27352763
* The REPARSE_DATA_BUFFER structure is defined in the Windows DDK (in

compat/mingw.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,6 @@ struct utsname {
125125
* trivial stubs
126126
*/
127127

128-
static inline int symlink(const char *oldpath, const char *newpath)
129-
{ errno = ENOSYS; return -1; }
130128
static inline int fchmod(int fildes, mode_t mode)
131129
{ errno = ENOSYS; return -1; }
132130
#ifndef __MINGW64_VERSION_MAJOR
@@ -217,6 +215,7 @@ int setitimer(int type, struct itimerval *in, struct itimerval *out);
217215
int sigaction(int sig, struct sigaction *in, struct sigaction *out);
218216
int link(const char *oldpath, const char *newpath);
219217
int uname(struct utsname *buf);
218+
int symlink(const char *target, const char *link);
220219
int readlink(const char *path, char *buf, size_t bufsiz);
221220

222221
/*

0 commit comments

Comments
 (0)