Skip to content

Commit 95d9d5e

Browse files
Thomas Rastgitster
authored andcommitted
tests --valgrind: provide a mode without --track-origins
With --valgrind=memcheck-fast, the tests run under memcheck but without the autodetected --track-origins. If you just run valgrind to see *if* there is any memory issue with your program, the extra information is not needed, and it comes at a roughly 30% hit in runtime. While it is possible to achieve the same through GIT_VALGRIND_OPTIONS, this should be more discoverable and hopefully encourage more users to run their tests with valgrind. Signed-off-by: Thomas Rast <[email protected]> Acked-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 952af35 commit 95d9d5e

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

t/README

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,11 @@ appropriately before running "make".
106106
'drd', but you may use any tool recognized by your valgrind
107107
installation.
108108

109+
As a special case, <tool> can be 'memcheck-fast', which uses
110+
memcheck but disables --track-origins. Use this if you are
111+
running tests in bulk, to see if there are _any_ memory
112+
issues.
113+
109114
Note that memcheck is run with the option --leak-check=no,
110115
as the git process is short-lived and some errors are not
111116
interesting. In order to run a single command under the same

t/valgrind/valgrind.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ base=$(basename "$0")
55
TOOL_OPTIONS='--leak-check=no'
66

77
case "$GIT_VALGRIND_MODE" in
8+
memcheck-fast)
9+
;;
810
memcheck)
911
VALGRIND_VERSION=$(valgrind --version)
1012
VALGRIND_MAJOR=$(expr "$VALGRIND_VERSION" : '[^0-9]*\([0-9]*\)')

0 commit comments

Comments
 (0)