builtin/credential: clear credential before exit

pks-t · gitster · commit 96c1655095ae · 2024-05-27T11:20:01.000-07:00
We never release memory associated with `struct credential`. Fix this
and mark the corresponding test as leak free.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/credential.c b/builtin/credential.c
@@ -39,5 +39,7 @@ int cmd_credential(int argc, const char **argv, const char *prefix UNUSED)
 	} else {
 		usage(usage_msg);
 	}
+
+	credential_clear(&c);
 	return 0;
 }
diff --git a/t/t0300-credentials.sh b/t/t0300-credentials.sh
@@ -1,6 +1,8 @@
 #!/bin/sh
 
 test_description='basic credential helper tests'
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-credential.sh
 

Original file line number	Diff line number	Diff line change
`@@ -39,5 +39,7 @@ int cmd_credential(int argc, const char *argv, const char prefix UNUSED)`
`39`	`39`	`} else {`
`40`	`40`	`usage(usage_msg);`
`41`	`41`	`}`
	`42`	`+`
	`43`	`+ credential_clear(&c);`
`42`	`44`	`return 0;`
`43`	`45`	`}`