commit-graph: fix memory leak

steadmon · gitster · commit 98552f252ad4 · 2019-05-07T13:49:28.000+09:00
Free the commit graph when verify_commit_graph_lite() reports an error.
Credit to OSS-Fuzz for finding this leak.

Signed-off-by: Josh Steadmon &lt;steadmon@google.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/commit-graph.c b/commit-graph.c
@@ -267,8 +267,10 @@ struct commit_graph *parse_commit_graph(void *graph_map, int fd,
 		last_chunk_offset = chunk_offset;
 	}
 
-	if (verify_commit_graph_lite(graph))
+	if (verify_commit_graph_lite(graph)) {
+		free(graph);
 		return NULL;
+	}
 
 	return graph;
 }

Original file line number	Diff line number	Diff line change
`@@ -267,8 +267,10 @@ struct commit_graph parse_commit_graph(void graph_map, int fd,`
`267`	`267`	`last_chunk_offset = chunk_offset;`
`268`	`268`	`}`
`269`	`269`
`270`		`- if (verify_commit_graph_lite(graph))`
	`270`	`+ if (verify_commit_graph_lite(graph)) {`
	`271`	`+ free(graph);`
`271`	`272`	`return NULL;`
	`273`	`+ }`
`272`	`274`
`273`	`275`	`return graph;`
`274`	`276`	`}`