test-lint: detect 'export FOO=bar'

Thomas Rast · gitster · commit 9968ffff0d09 · 2013-07-08T10:21:33.000-07:00
Some shells do not understand the one-line construct, and instead need

  FOO=bar &amp;&amp;
  export FOO

Detect this in the test-lint target.

Signed-off-by: Thomas Rast &lt;trast@inf.ethz.ch&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
@@ -21,6 +21,7 @@ sub err {
 	/^\s*declare\s+/ and err 'arrays/declare not portable';
 	/^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)';
 	/test\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';
+	/^\s*export\s+[^=]*=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)';
 	# this resets our $. for each file
 	close ARGV if eof;
 }

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@ sub err {`
`21`	`21`	`/^\s*declare\s+/ and err 'arrays/declare not portable';`
`22`	`22`	`/^\s[^#]\swhich\s/ and err 'which is not portable (please use type)';`
`23`	`23`	`/test\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';`
	`24`	`+ /^\sexport\s+[^=]=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)';`
`24`	`25`	`# this resets our $. for each file`
`25`	`26`	`close ARGV if eof;`
`26`	`27`	`}`