Skip to content

Commit 99acb0f

Browse files
committed
Merge branch 'ah/autoconf-fixes'
"./configure --with-expat=no" did not work as a way to refuse use of the expat library on a system with the library installed, which has been corrected. * ah/autoconf-fixes: configure.ac: always save NO_ICONV to config.status configure.ac: don't overwrite NO_CURL option configure.ac: don't overwrite NO_EXPAT option
2 parents fea92e4 + fb8f726 commit 99acb0f

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

configure.ac

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -546,6 +546,8 @@ fi
546546
# git-http-push are not built, and you cannot use http:// and https://
547547
# transports.
548548

549+
if test -z "$NO_CURL"; then
550+
549551
GIT_STASH_FLAGS($CURLDIR)
550552

551553
AC_CHECK_LIB([curl], [curl_global_init],
@@ -554,6 +556,8 @@ AC_CHECK_LIB([curl], [curl_global_init],
554556

555557
GIT_UNSTASH_FLAGS($CURLDIR)
556558

559+
fi
560+
557561
GIT_CONF_SUBST([NO_CURL])
558562

559563
if test -z "$NO_CURL"; then
@@ -581,6 +585,8 @@ fi
581585
# Define NO_EXPAT if you do not have expat installed. git-http-push is
582586
# not built, and you cannot push using http:// and https:// transports.
583587

588+
if test -z "$NO_EXPAT"; then
589+
584590
GIT_STASH_FLAGS($EXPATDIR)
585591

586592
AC_CHECK_LIB([expat], [XML_ParserCreate],
@@ -589,6 +595,8 @@ AC_CHECK_LIB([expat], [XML_ParserCreate],
589595

590596
GIT_UNSTASH_FLAGS($EXPATDIR)
591597

598+
fi
599+
592600
GIT_CONF_SUBST([NO_EXPAT])
593601

594602
#
@@ -636,14 +644,15 @@ LIBS="$old_LIBS"
636644
GIT_UNSTASH_FLAGS($ICONVDIR)
637645

638646
GIT_CONF_SUBST([NEEDS_LIBICONV])
639-
GIT_CONF_SUBST([NO_ICONV])
640647

641648
if test -n "$NO_ICONV"; then
642649
NEEDS_LIBICONV=
643650
fi
644651

645652
fi
646653

654+
GIT_CONF_SUBST([NO_ICONV])
655+
647656
#
648657
# Define NO_DEFLATE_BOUND if deflateBound is missing from zlib.
649658

0 commit comments

Comments
 (0)