Skip to content

Commit 9bb8145

Browse files
avargitster
authored andcommitted
perf README: correct docs for 3c8f12c regression
Since 3c8f12c ("test-lib: reorder and include GIT-BUILD-OPTIONS a lot earlier", 2012-06-24) the suggested advice of overriding GIT_BUILD_DIR has not worked. We've printed a hard error like this given e.g. GIT_BUILD_DIR=/home/avar/g/git: /bin-wrappers/git is not executable; using GIT_EXEC_PATH error: You haven't built things yet, have you? Let's just suggest that the user run other gits via the "run" script. That'll do the right thing for setting the path to the other git, and running the "aggregate.perl" scripts afterwards will work. As an aside, if setting GIT_BUILD_DIR had still worked, then the MODERN_GIT feature/fix added in 1a0962d ("t/perf: fix regression in testing older versions of git", 2016-06-22) would have broke. Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]>
1 parent 0baf78e commit 9bb8145

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/perf/README

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ call the aggregation script to summarize the results:
4545

4646
$ ./p0001-rev-list.sh
4747
[...]
48-
$ GIT_BUILD_DIR=/path/to/other/git ./p0001-rev-list.sh
48+
$ ./run /path/to/other/git -- ./p0001-rev-list.sh
4949
[...]
5050
$ ./aggregate.perl . /path/to/other/git ./p0001-rev-list.sh
5151

0 commit comments

Comments
 (0)