Skip to content

Commit 9c575b0

Browse files
vdyegitster
authored andcommitted
ref-filter.c: rename 'ref_filter_handler()' to 'filter_one()'
Rename 'ref_filter_handler()' to 'filter_one()' to more clearly distinguish it from other ref filtering callbacks that will be added in later patches. The "*_one()" naming convention is common throughout the codebase for iteration callbacks. Signed-off-by: Victoria Dye <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent e7574b0 commit 9c575b0

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

ref-filter.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2686,7 +2686,7 @@ struct ref_filter_cbdata {
26862686
* A call-back given to for_each_ref(). Filter refs and keep them for
26872687
* later object processing.
26882688
*/
2689-
static int ref_filter_handler(const char *refname, const struct object_id *oid, int flag, void *cb_data)
2689+
static int filter_one(const char *refname, const struct object_id *oid, int flag, void *cb_data)
26902690
{
26912691
struct ref_filter_cbdata *ref_cbdata = cb_data;
26922692
struct ref_filter *filter = ref_cbdata->filter;
@@ -2917,15 +2917,15 @@ int filter_refs(struct ref_array *array, struct ref_filter *filter, unsigned int
29172917
* of filter_ref_kind().
29182918
*/
29192919
if (filter->kind == FILTER_REFS_BRANCHES)
2920-
ret = for_each_fullref_in("refs/heads/", ref_filter_handler, &ref_cbdata);
2920+
ret = for_each_fullref_in("refs/heads/", filter_one, &ref_cbdata);
29212921
else if (filter->kind == FILTER_REFS_REMOTES)
2922-
ret = for_each_fullref_in("refs/remotes/", ref_filter_handler, &ref_cbdata);
2922+
ret = for_each_fullref_in("refs/remotes/", filter_one, &ref_cbdata);
29232923
else if (filter->kind == FILTER_REFS_TAGS)
2924-
ret = for_each_fullref_in("refs/tags/", ref_filter_handler, &ref_cbdata);
2924+
ret = for_each_fullref_in("refs/tags/", filter_one, &ref_cbdata);
29252925
else if (filter->kind & FILTER_REFS_ALL)
2926-
ret = for_each_fullref_in_pattern(filter, ref_filter_handler, &ref_cbdata);
2926+
ret = for_each_fullref_in_pattern(filter, filter_one, &ref_cbdata);
29272927
if (!ret && (filter->kind & FILTER_REFS_DETACHED_HEAD))
2928-
head_ref(ref_filter_handler, &ref_cbdata);
2928+
head_ref(filter_one, &ref_cbdata);
29292929
}
29302930

29312931
clear_contains_cache(&filter->internal.contains_cache);

0 commit comments

Comments
 (0)