Skip to content

Commit 9d15b1e

Browse files
peffgitster
authored andcommitted
t/lib-httpd: respect $HTTPD_PROTO in expect_askpass()
When the HTTP tests are run with LIB_HTTPD_SSL in the environment, then we access the test server as https://. This causes expect_askpass to complain, because it tries to blindly match "http://" in the prompt shown to the user. We can adjust this to use $HTTPD_PROTO, which is set during the setup phase. Note that this is enough for t5551 and t5559 to pass when run with https, but there are similar problems in other scripts that will need to be fixed before the whole suite can run with LIB_HTTPD_SSL. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent b71a2bf commit 9d15b1e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

t/lib-httpd.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -280,11 +280,11 @@ expect_askpass() {
280280
none)
281281
;;
282282
pass)
283-
echo "askpass: Password for 'http://$2@$dest': "
283+
echo "askpass: Password for '$HTTPD_PROTO://$2@$dest': "
284284
;;
285285
both)
286-
echo "askpass: Username for 'http://$dest': "
287-
echo "askpass: Password for 'http://$2@$dest': "
286+
echo "askpass: Username for '$HTTPD_PROTO://$dest': "
287+
echo "askpass: Password for '$HTTPD_PROTO://$2@$dest': "
288288
;;
289289
*)
290290
false

0 commit comments

Comments
 (0)