Skip to content

Commit 9ddf172

Browse files
jrngitster
authored andcommitted
declare 1-bit bitfields to be unsigned
As "gcc -pedantic" notices, a two's complement 1-bit signed integer cannot represent the value '1'. dir.c: In function 'init_pathspec': dir.c:1291:4: warning: overflow in implicit constant conversion [-Woverflow] In the spirit of v1.7.1-rc1~10 (2010-04-06), 'unsigned' is what was intended, so let's make the flags unsigned. Signed-off-by: Jonathan Nieder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent f577b92 commit 9ddf172

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

cache.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -503,13 +503,13 @@ extern int ie_modified(const struct index_state *, struct cache_entry *, struct
503503
struct pathspec {
504504
const char **raw; /* get_pathspec() result, not freed by free_pathspec() */
505505
int nr;
506-
int has_wildcard:1;
507-
int recursive:1;
506+
unsigned int has_wildcard:1;
507+
unsigned int recursive:1;
508508
int max_depth;
509509
struct pathspec_item {
510510
const char *match;
511511
int len;
512-
int has_wildcard:1;
512+
unsigned int has_wildcard:1;
513513
} *items;
514514
};
515515

0 commit comments

Comments
 (0)