Skip to content

Commit 9e11398

Browse files
mfwittenjrn
authored andcommitted
vcs-svn: a void function shouldn't try to return something
As v1.7.4-rc0~184 (2010-10-04) and C99 §6.8.6.4.1 remind us, standard C does not permit returning an expression of type void, even for a tail call. Noticed with gcc -pedantic: vcs-svn/svndump.c: In function 'handle_node': vcs-svn/svndump.c:213:3: warning: ISO C forbids 'return' with expression, in function returning void [-pedantic] [jn: with simplified log message] Signed-off-by: Michael Witten <[email protected]> Signed-off-by: Jonathan Nieder <[email protected]>
1 parent 4c502d6 commit 9e11398

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

vcs-svn/svndump.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,8 @@ static void handle_node(void)
214214
if (have_text || have_props || node_ctx.srcRev)
215215
die("invalid dump: deletion node has "
216216
"copyfrom info, text, or properties");
217-
return repo_delete(node_ctx.dst);
217+
repo_delete(node_ctx.dst);
218+
return;
218219
}
219220
if (node_ctx.action == NODEACT_REPLACE) {
220221
repo_delete(node_ctx.dst);

0 commit comments

Comments
 (0)