Skip to content

Commit 9eeff2f

Browse files
committed
config.mak.uname: add hint on uname_R for MacOS X
I always have to scratch my head every time I see this cryptic pattern "[15678]\."; leave a short note to remind the maintainer and the reviewers. Signed-off-by: Junio C Hamano <[email protected]>
1 parent 9c7a0be commit 9eeff2f

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

config.mak.uname

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,10 @@ ifeq ($(uname_S),Darwin)
8686
NEEDS_CRYPTO_WITH_SSL = YesPlease
8787
NEEDS_SSL_WITH_CRYPTO = YesPlease
8888
NEEDS_LIBICONV = YesPlease
89+
# Note: $(uname_R) gives us the underlying Darwin version.
90+
# - MacOS 10.0.* and MacOS 10.1.0 = Darwin 1.*
91+
# - MacOS 10.x.* = Darwin (x+4).* for (1 <= x)
92+
# i.e. "begins with [15678] and a dot" means "10.4.* or older".
8993
ifeq ($(shell expr "$(uname_R)" : '[15678]\.'),2)
9094
OLD_ICONV = UnfortunatelyYes
9195
NO_APPLE_COMMON_CRYPTO = YesPlease

0 commit comments

Comments
 (0)