Skip to content

Commit 9ef5e2a

Browse files
jacqueriegitster
authored andcommitted
branch.c: delete size check of newly tracked branch names
Since commit 6f084a5 the length of a newly tracked branch name was limited to 1019 = 1024 - 7 - 7 - 1 characters, a bound derived by having to store this name in a char[1024] called key with two strings of length at most 7 and a '\0' character. This was no longer necessary as of commit a9f2c13, which uses a strbuf (documented in Documentation/technical/api-strbuf.txt) to store this value. Remove this unneeded check to allow branch names longer than 1019 characters. Signed-off-by: Jacopo Notarstefano <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 2f93541 commit 9ef5e2a

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

branch.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,6 @@ static int setup_tracking(const char *new_ref, const char *orig_ref,
114114
struct tracking tracking;
115115
int config_flags = quiet ? 0 : BRANCH_CONFIG_VERBOSE;
116116

117-
if (strlen(new_ref) > 1024 - 7 - 7 - 1)
118-
return error(_("Tracking not set up: name too long: %s"),
119-
new_ref);
120-
121117
memset(&tracking, 0, sizeof(tracking));
122118
tracking.spec.dst = (char *)orig_ref;
123119
if (for_each_remote(find_tracked_branch, &tracking))

0 commit comments

Comments
 (0)