Skip to content

Commit 9f27318

Browse files
committed
gitk: place file name arguments after options in msgfmt call
The build process fails in POSIXLY_CORRECT mode: $ gitk@master:1005> POSIXLY_CORRECT=1 make * new Tcl/Tk interpreter location GEN gitk-wish Generating catalog po/zh_cn.msg msgfmt --statistics --tcl po/zh_cn.po -l zh_cn -d po/ msgfmt: --tcl requires a "-l locale" specification Try 'msgfmt --help' for more information. make: *** [Makefile:76: po/zh_cn.msg] Error 1 The reason is that option arguments cannot occur after the first non-option argument. Move the file name last. Reported-by: Nathan Royce <[email protected]> Signed-off-by: Johannes Sixt <[email protected]>
1 parent 3fdbf18 commit 9f27318

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ update-po:: $(PO_TEMPLATE)
7373
$(foreach p, $(ALL_POFILES), echo Updating $p ; msgmerge -U $p $(PO_TEMPLATE) ; )
7474
$(ALL_MSGFILES): %.msg : %.po
7575
@echo Generating catalog $@
76-
$(MSGFMT) --statistics --tcl $< -l $(basename $(notdir $<)) -d $(dir $@)
76+
$(MSGFMT) --statistics --tcl -l $(basename $(notdir $<)) -d $(dir $@) $<
7777

7878
.PHONY: all install uninstall clean update-po
7979
.PHONY: FORCE

0 commit comments

Comments
 (0)