Skip to content

Commit 9fd3693

Browse files
pks-tgitster
authored andcommitted
ci: add missing dependency for TTY prereq
In "t/lib-terminal.sh", we declare a lazy prerequisite for tests that require a TTY. The prerequisite uses a Perl script to figure out whether we do have a usable TTY or not and thus implicitly depends on the PERL prerequisite, as well. Furthermore though, the script requires another dependency that is easy to miss, namely on the IO::Pty module. If that module is not installed, then the script will exit early due to an reason unrelated to missing TTYs. This easily leads to missing test coverage. But most importantly, our CI systems are missing this dependency and thus don't execute those tests at all. Fix this. Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 4365c6f commit 9fd3693

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ci/install-dependencies.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ alpine-*)
2727
apk add --update shadow sudo build-base curl-dev openssl-dev expat-dev gettext \
2828
pcre2-dev python3 musl-libintl perl-utils ncurses \
2929
apache2 apache2-http2 apache2-proxy apache2-ssl apache2-webdav apr-util-dbd_sqlite3 \
30-
bash cvs gnupg perl-cgi perl-dbd-sqlite >/dev/null
30+
bash cvs gnupg perl-cgi perl-dbd-sqlite perl-io-tty >/dev/null
3131
;;
3232
fedora-*)
3333
dnf -yq update >/dev/null &&
@@ -42,7 +42,7 @@ ubuntu-*)
4242
language-pack-is libsvn-perl apache2 cvs cvsps git gnupg subversion \
4343
make libssl-dev libcurl4-openssl-dev libexpat-dev wget sudo default-jre \
4444
tcl tk gettext zlib1g-dev perl-modules liberror-perl libauthen-sasl-perl \
45-
libemail-valid-perl libio-socket-ssl-perl libnet-smtp-ssl-perl libdbd-sqlite3-perl libcgi-pm-perl \
45+
libemail-valid-perl libio-pty-perl libio-socket-ssl-perl libnet-smtp-ssl-perl libdbd-sqlite3-perl libcgi-pm-perl \
4646
${CC_PACKAGE:-${CC:-gcc}} $PYTHON_PACKAGE
4747

4848
mkdir --parents "$CUSTOM_PATH"

0 commit comments

Comments
 (0)