Skip to content

Commit a0f58c5

Browse files
dakhubgitgitster
authored andcommitted
builtin/blame.c: struct blame_entry does not need a prev link
Signed-off-by: David Kastrup <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 79fcbf7 commit a0f58c5

File tree

1 file changed

+2
-11
lines changed

1 file changed

+2
-11
lines changed

builtin/blame.c

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,6 @@ static void drop_origin_blob(struct origin *o)
197197
* scoreboard structure, sorted by the target line number.
198198
*/
199199
struct blame_entry {
200-
struct blame_entry *prev;
201200
struct blame_entry *next;
202201

203202
/* the first line of this group in the final image;
@@ -282,8 +281,6 @@ static void coalesce(struct scoreboard *sb)
282281
ent->s_lno + ent->num_lines == next->s_lno) {
283282
ent->num_lines += next->num_lines;
284283
ent->next = next->next;
285-
if (ent->next)
286-
ent->next->prev = ent;
287284
origin_decref(next->suspect);
288285
free(next);
289286
ent->score = 0;
@@ -534,7 +531,7 @@ static void add_blame_entry(struct scoreboard *sb, struct blame_entry *e)
534531
prev = ent;
535532

536533
/* prev, if not NULL, is the last one that is below e */
537-
e->prev = prev;
534+
538535
if (prev) {
539536
e->next = prev->next;
540537
prev->next = e;
@@ -543,8 +540,6 @@ static void add_blame_entry(struct scoreboard *sb, struct blame_entry *e)
543540
e->next = sb->ent;
544541
sb->ent = e;
545542
}
546-
if (e->next)
547-
e->next->prev = e;
548543
}
549544

550545
/*
@@ -555,14 +550,12 @@ static void add_blame_entry(struct scoreboard *sb, struct blame_entry *e)
555550
*/
556551
static void dup_entry(struct blame_entry *dst, struct blame_entry *src)
557552
{
558-
struct blame_entry *p, *n;
553+
struct blame_entry *n;
559554

560-
p = dst->prev;
561555
n = dst->next;
562556
origin_incref(src->suspect);
563557
origin_decref(dst->suspect);
564558
memcpy(dst, src, sizeof(*src));
565-
dst->prev = p;
566559
dst->next = n;
567560
dst->score = 0;
568561
}
@@ -2502,8 +2495,6 @@ int cmd_blame(int argc, const char **argv, const char *prefix)
25022495
ent->suspect = o;
25032496
ent->s_lno = bottom;
25042497
ent->next = next;
2505-
if (next)
2506-
next->prev = ent;
25072498
origin_incref(o);
25082499
}
25092500
origin_decref(o);

0 commit comments

Comments
 (0)