Skip to content

Commit a118796

Browse files
dschodscho
committed
Merge branch 'dscho-avoid-d-f-conflict-in-vs-master'
Merge this early to resolve merge conflicts early. Signed-off-by: Johannes Schindelin <[email protected]>
2 parents 2e0c2ab + dd2a525 commit a118796

File tree

4 files changed

+28
-26
lines changed

4 files changed

+28
-26
lines changed

‎config.mak.uname

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,7 @@ vcxproj:
768768

769769
# Make .vcxproj files and add them
770770
perl contrib/buildsystems/generate -g Vcxproj
771-
git add -f git.sln {*,*/lib,t/helper/*}/*.vcxproj
771+
git add -f git.sln {*,*/lib.proj,t/helper/*}/*.vcxproj
772772

773773
# Generate the LinkOrCopyBuiltins.targets and LinkOrCopyRemoteHttp.targets file
774774
(echo '<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">' && \
@@ -778,16 +778,16 @@ vcxproj:
778778
echo ' <Copy SourceFiles="$$(OutDir)\git.exe" DestinationFiles="$$(OutDir)\'"$$name"'" SkipUnchangedFiles="true" UseHardlinksIfPossible="true" />'; \
779779
done && \
780780
echo ' </Target>' && \
781-
echo '</Project>') >git/LinkOrCopyBuiltins.targets
781+
echo '</Project>') >git.proj/LinkOrCopyBuiltins.targets
782782
(echo '<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">' && \
783783
echo ' <Target Name="CopyBuiltins_AfterBuild" AfterTargets="AfterBuild">' && \
784784
for name in $(REMOTE_CURL_ALIASES); \
785785
do \
786786
echo ' <Copy SourceFiles="$$(OutDir)\'"$(REMOTE_CURL_PRIMARY)"'" DestinationFiles="$$(OutDir)\'"$$name"'" SkipUnchangedFiles="true" UseHardlinksIfPossible="true" />'; \
787787
done && \
788788
echo ' </Target>' && \
789-
echo '</Project>') >git-remote-http/LinkOrCopyRemoteHttp.targets
790-
git add -f git/LinkOrCopyBuiltins.targets git-remote-http/LinkOrCopyRemoteHttp.targets
789+
echo '</Project>') >git-remote-http.proj/LinkOrCopyRemoteHttp.targets
790+
git add -f git.proj/LinkOrCopyBuiltins.targets git-remote-http.proj/LinkOrCopyRemoteHttp.targets
791791

792792
# Add generated headers
793793
$(MAKE) MSVC=1 SKIP_VCPKG=1 prefix=/mingw64 $(GENERATED_H)

‎contrib/buildsystems/Generators/Vcxproj.pm

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ sub createProject {
5858
my $uuid = generate_guid($name);
5959
$$build_structure{"$prefix${target}_GUID"} = $uuid;
6060
my $vcxproj = $target;
61-
$vcxproj =~ s/(.*\/)?(.*)/$&\/$2.vcxproj/;
62-
$vcxproj =~ s/([^\/]*)(\/lib)\/(lib.vcxproj)/$1$2\/$1_$3/;
61+
$vcxproj =~ s/(.*\/)?(.*)/$&.proj\/$2.vcxproj/;
62+
$vcxproj =~ s/([^\/]*)(\/lib\.proj)\/(lib.vcxproj)/$1$2\/$1_$3/;
6363
$$build_structure{"$prefix${target}_VCXPROJ"} = $vcxproj;
6464

6565
my @srcs = sort(map("$rel_dir\\$_", @{$$build_structure{"$prefix${name}_SOURCES"}}));
@@ -89,7 +89,9 @@ sub createProject {
8989
$defines =~ s/>/&gt;/g;
9090
$defines =~ s/\'//g;
9191

92-
die "Could not create the directory $target for $label project!\n" unless (-d "$target" || mkdir "$target");
92+
my $dir = $vcxproj;
93+
$dir =~ s/\/[^\/]*$//;
94+
die "Could not create the directory $dir for $label project!\n" unless (-d "$dir" || mkdir "$dir");
9395

9496
open F, ">$vcxproj" or die "Could not open $vcxproj for writing!\n";
9597
binmode F, ":crlf :utf8";
@@ -237,7 +239,7 @@ EOM
237239

238240
print F << "EOM";
239241
<ItemGroup>
240-
<ProjectReference Include="$cdup\\libgit\\libgit.vcxproj">
242+
<ProjectReference Include="$cdup\\libgit.proj\\libgit.vcxproj">
241243
<Project>$uuid_libgit</Project>
242244
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
243245
</ProjectReference>
@@ -252,7 +254,7 @@ EOM
252254
}
253255
if (!($name =~ 'xdiff')) {
254256
print F << "EOM";
255-
<ProjectReference Include="$cdup\\xdiff\\lib\\xdiff_lib.vcxproj">
257+
<ProjectReference Include="$cdup\\xdiff\\lib.proj\\xdiff_lib.vcxproj">
256258
<Project>$uuid_xdiff_lib</Project>
257259
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
258260
</ProjectReference>
@@ -261,7 +263,7 @@ EOM
261263
if ($name =~ /(test-(line-buffer|svn-fe)|^git-remote-testsvn)\.exe$/) {
262264
my $uuid_vcs_svn_lib = $$build_structure{"LIBS_vcs-svn/lib_GUID"};
263265
print F << "EOM";
264-
<ProjectReference Include="$cdup\\vcs-svn\\lib\\vcs-svn_lib.vcxproj">
266+
<ProjectReference Include="$cdup\\vcs-svn\\lib.proj\\vcs-svn_lib.vcxproj">
265267
<Project>$uuid_vcs_svn_lib</Project>
266268
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
267269
</ProjectReference>
@@ -338,7 +340,7 @@ sub createGlueProject {
338340
my $vcxproj = $build_structure{"APPS_${appname}_VCXPROJ"};
339341
$vcxproj =~ s/\//\\/g;
340342
$appname =~ s/.*\///;
341-
print F "\"${appname}\", \"${vcxproj}\", \"${uuid}\"";
343+
print F "\"${appname}.proj\", \"${vcxproj}\", \"${uuid}\"";
342344
print F "$SLN_POST";
343345
}
344346
foreach (@libs) {
@@ -348,7 +350,7 @@ sub createGlueProject {
348350
my $vcxproj = $build_structure{"LIBS_${libname}_VCXPROJ"};
349351
$vcxproj =~ s/\//\\/g;
350352
$libname =~ s/\//_/g;
351-
print F "\"${libname}\", \"${vcxproj}\", \"${uuid}\"";
353+
print F "\"${libname}.proj\", \"${vcxproj}\", \"${uuid}\"";
352354
print F "$SLN_POST";
353355
}
354356

‎t/t5505-remote.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -836,8 +836,8 @@ test_expect_success '"remote show" does not show symbolic refs' '
836836
(
837837
cd three &&
838838
git remote show origin >output &&
839-
! grep "^ *HEAD$" < output &&
840-
! grep -i stale < output
839+
! grep "^ *HEAD$" <output &&
840+
! grep -i stale <output
841841
)
842842
'
843843

@@ -1040,7 +1040,7 @@ test_expect_success 'migrate a remote from named file in $GIT_DIR/branches' '
10401040
(
10411041
cd six &&
10421042
git remote rm origin &&
1043-
mkdir .git/branches &&
1043+
mkdir -p .git/branches &&
10441044
echo "$origin_url#main" >.git/branches/origin &&
10451045
git remote rename origin origin &&
10461046
test_path_is_missing .git/branches/origin &&
@@ -1055,8 +1055,8 @@ test_expect_success 'migrate a remote from named file in $GIT_DIR/branches (2)'
10551055
(
10561056
cd seven &&
10571057
git remote rm origin &&
1058-
mkdir .git/branches &&
1059-
echo "quux#foom" > .git/branches/origin &&
1058+
mkdir -p .git/branches &&
1059+
echo "quux#foom" >.git/branches/origin &&
10601060
git remote rename origin origin &&
10611061
test_path_is_missing .git/branches/origin &&
10621062
test "$(git config remote.origin.url)" = "quux" &&

‎t/t5516-fetch-push.sh

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -980,8 +980,8 @@ test_expect_success 'fetch with branches' '
980980
mk_empty testrepo &&
981981
git branch second $the_first_commit &&
982982
git checkout second &&
983-
mkdir testrepo/.git/branches &&
984-
echo ".." > testrepo/.git/branches/branch1 &&
983+
mkdir -p testrepo/.git/branches &&
984+
echo ".." >testrepo/.git/branches/branch1 &&
985985
(
986986
cd testrepo &&
987987
git fetch branch1 &&
@@ -994,8 +994,8 @@ test_expect_success 'fetch with branches' '
994994

995995
test_expect_success 'fetch with branches containing #' '
996996
mk_empty testrepo &&
997-
mkdir testrepo/.git/branches &&
998-
echo "..#second" > testrepo/.git/branches/branch2 &&
997+
mkdir -p testrepo/.git/branches &&
998+
echo "..#second" >testrepo/.git/branches/branch2 &&
999999
(
10001000
cd testrepo &&
10011001
git fetch branch2 &&
@@ -1011,8 +1011,8 @@ test_expect_success 'push with branches' '
10111011
git checkout second &&
10121012
10131013
test_when_finished "rm -rf .git/branches" &&
1014-
mkdir .git/branches &&
1015-
echo "testrepo" > .git/branches/branch1 &&
1014+
mkdir -p .git/branches &&
1015+
echo "testrepo" >.git/branches/branch1 &&
10161016
10171017
git push branch1 &&
10181018
(
@@ -1027,8 +1027,8 @@ test_expect_success 'push with branches containing #' '
10271027
mk_empty testrepo &&
10281028
10291029
test_when_finished "rm -rf .git/branches" &&
1030-
mkdir .git/branches &&
1031-
echo "testrepo#branch3" > .git/branches/branch2 &&
1030+
mkdir -p .git/branches &&
1031+
echo "testrepo#branch3" >.git/branches/branch2 &&
10321032
10331033
git push branch2 &&
10341034
(
@@ -1557,7 +1557,7 @@ EOF
15571557
git init no-thin &&
15581558
git --git-dir=no-thin/.git config receive.unpacklimit 0 &&
15591559
git push no-thin/.git refs/heads/main:refs/heads/foo &&
1560-
echo modified >> path1 &&
1560+
echo modified >>path1 &&
15611561
git commit -am modified &&
15621562
git repack -adf &&
15631563
rcvpck="git receive-pack --reject-thin-pack-for-testing" &&

0 commit comments

Comments
 (0)