Skip to content

Commit a179a30

Browse files
chriscoolgitster
authored andcommitted
bisect: report bad rev better
The previous one overwrote the variable used to report the bad input when the input is actually bad, and we did not give a useful enough information. This corrects it. Signed-off-by: Christian Couder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent e338907 commit a179a30

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

git-bisect.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,9 @@ bisect_state() {
155155
shift
156156
for rev in "$@"
157157
do
158-
rev=$(git rev-parse --verify "$rev^{commit}") ||
158+
sha=$(git rev-parse --verify "$rev^{commit}") ||
159159
die "Bad rev input: $rev"
160-
bisect_write "$state" "$rev"
160+
bisect_write "$state" "$sha"
161161
done ;;
162162
*,bad)
163163
die "'git bisect bad' can take only one argument." ;;

0 commit comments

Comments
 (0)