Skip to content

Commit a28d094

Browse files
newrengitster
authored andcommitted
merge-ort: mark a few more conflict messages as omittable
path_msg() has the ability to mark messages as omittable, designed for remerge-diff where we'll instead be showing conflict messages as diff headers for a subsequent diff. While all these messages are very useful when trying to create a merge initially, early use with the --remerge-diff feature (the only user of this omittable conflict message capability), suggests that the particular messages marked in this commit are just noise when trying to see what changes users made to create a merge commit. Mark them as omittable. Note that there were already a few messages marked as omittable in merge-ort when doing a remerge-diff, because the development of --remerge-diff preceded the upstreaming of merge-ort and I was trying to ensure merge-ort could handle all the necessary requirements. See commit c5a6f65 ("merge-ort: add modify/delete handling and delayed output processing", 2020-12-03) for the initial details. For some examples of already-marked-as-omittable messages, see either "Auto-merging <path>" or some of the submodule update hints. This commit just adds two more messages that should also be omittable. Signed-off-by: Elijah Newren <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 24dbdab commit a28d094

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

merge-ort.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2420,15 +2420,15 @@ static void apply_directory_rename_modifications(struct merge_options *opt,
24202420
*/
24212421
ci->path_conflict = 1;
24222422
if (pair->status == 'A')
2423-
path_msg(opt, new_path, 0,
2423+
path_msg(opt, new_path, 1,
24242424
_("CONFLICT (file location): %s added in %s "
24252425
"inside a directory that was renamed in %s, "
24262426
"suggesting it should perhaps be moved to "
24272427
"%s."),
24282428
old_path, branch_with_new_path,
24292429
branch_with_dir_rename, new_path);
24302430
else
2431-
path_msg(opt, new_path, 0,
2431+
path_msg(opt, new_path, 1,
24322432
_("CONFLICT (file location): %s renamed to %s "
24332433
"in %s, inside a directory that was renamed "
24342434
"in %s, suggesting it should perhaps be "

0 commit comments

Comments
 (0)