help -i: properly error out if no info viewer can be found

g-pape · gitster · commit a29aa47da79c · 2009-10-27T23:05:24.000-07:00
With this commit, git help -i <cmd> prints an error message and exits non-zero instead of being silent and exit code 0. Reported by Trent W. Buck through http://bugs.debian.org/537664 Signed-off-by: Gerrit Pape <pape@smarden.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/builtin-help.c b/builtin-help.c
@@ -372,6 +372,7 @@ static void show_info_page(const char *git_cmd)
 	const char *page = cmd_to_page(git_cmd);
 	setenv("INFOPATH", system_path(GIT_INFO_PATH), 1);
 	execlp("info", "info", "gitman", page, NULL);
+	die("no info viewer handled the request");
 }
 
 static void get_html_page_path(struct strbuf *page_path, const char *page)

Original file line number	Diff line number	Diff line change
`@@ -372,6 +372,7 @@ static void show_info_page(const char *git_cmd)`
`372`	`372`	`const char *page = cmd_to_page(git_cmd);`
`373`	`373`	`setenv("INFOPATH", system_path(GIT_INFO_PATH), 1);`
`374`	`374`	`execlp("info", "info", "gitman", page, NULL);`
	`375`	`+ die("no info viewer handled the request");`
`375`	`376`	`}`
`376`	`377`
`377`	`378`	`static void get_html_page_path(struct strbuf page_path, const char page)`