Skip to content

Commit a4d695d

Browse files
committed
upload-pack.c: do not pass confusing cb_data to mark_our_ref()
The callee does not use cb_data, and the caller is an intermediate function in a callchain that later wants to use the cb_data for its own use. Clarify the code by breaking the dataflow explicitly by not passing cb_data down to mark_our_ref(). Signed-off-by: Junio C Hamano <[email protected]>
1 parent a4dfee0 commit a4d695d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

upload-pack.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -742,7 +742,7 @@ static int send_ref(const char *refname, const unsigned char *sha1, int flag, vo
742742
const char *refname_nons = strip_namespace(refname);
743743
unsigned char peeled[20];
744744

745-
if (mark_our_ref(refname, sha1, flag, cb_data))
745+
if (mark_our_ref(refname, sha1, flag, NULL))
746746
return 0;
747747

748748
if (capabilities)

0 commit comments

Comments
 (0)