Skip to content

Commit a926c4b

Browse files
avargitster
authored andcommitted
tests: remove most uses of C_LOCALE_OUTPUT
As a follow-up to d162b25 (tests: remove support for GIT_TEST_GETTEXT_POISON, 2021-01-20) remove those uses of the now always true C_LOCALE_OUTPUT prerequisite from those tests which declare it as an argument to test_expect_{success,failure}. Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 780aa0a commit a926c4b

17 files changed

+41
-41
lines changed

t/t0000-basic.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ test_expect_success 'pretend we have a mix of all possible results' '
271271
EOF
272272
'
273273

274-
test_expect_success C_LOCALE_OUTPUT 'test --verbose' '
274+
test_expect_success 'test --verbose' '
275275
run_sub_test_lib_test_err \
276276
t1234-verbose "test verbose" --verbose <<-\EOF &&
277277
test_expect_success "passing test" true

t/t0201-gettext-fallbacks.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ test_expect_success 'sanity: $GIT_INTERNAL_GETTEXT_TEST_FALLBACKS is set' '
1818
test -n "$GIT_INTERNAL_GETTEXT_TEST_FALLBACKS"
1919
'
2020

21-
test_expect_success C_LOCALE_OUTPUT 'sanity: $GIT_INTERNAL_GETTEXT_SH_SCHEME" is fallthrough' '
21+
test_expect_success 'sanity: $GIT_INTERNAL_GETTEXT_SH_SCHEME" is fallthrough' '
2222
echo fallthrough >expect &&
2323
echo $GIT_INTERNAL_GETTEXT_SH_SCHEME >actual &&
2424
test_cmp expect actual

t/t1430-bad-ref-name.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ test_expect_success 'push cannot create a badly named ref' '
125125
! grep -e "broken\.\.\.ref" output
126126
'
127127

128-
test_expect_failure C_LOCALE_OUTPUT 'push --mirror can delete badly named ref' '
128+
test_expect_failure 'push --mirror can delete badly named ref' '
129129
top=$(pwd) &&
130130
git init src &&
131131
git init dest &&

t/t1512-rev-parse-disambiguation.sh

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -314,39 +314,39 @@ test_expect_success 'ambiguous short sha1 ref' '
314314
grep "refname.*${REF}.*ambiguous" err
315315
'
316316

317-
test_expect_success C_LOCALE_OUTPUT 'ambiguity errors are not repeated (raw)' '
317+
test_expect_success 'ambiguity errors are not repeated (raw)' '
318318
test_must_fail git rev-parse 00000 2>stderr &&
319319
grep "is ambiguous" stderr >errors &&
320320
test_line_count = 1 errors
321321
'
322322

323-
test_expect_success C_LOCALE_OUTPUT 'ambiguity errors are not repeated (treeish)' '
323+
test_expect_success 'ambiguity errors are not repeated (treeish)' '
324324
test_must_fail git rev-parse 00000:foo 2>stderr &&
325325
grep "is ambiguous" stderr >errors &&
326326
test_line_count = 1 errors
327327
'
328328

329-
test_expect_success C_LOCALE_OUTPUT 'ambiguity errors are not repeated (peel)' '
329+
test_expect_success 'ambiguity errors are not repeated (peel)' '
330330
test_must_fail git rev-parse 00000^{commit} 2>stderr &&
331331
grep "is ambiguous" stderr >errors &&
332332
test_line_count = 1 errors
333333
'
334334

335-
test_expect_success C_LOCALE_OUTPUT 'ambiguity hints' '
335+
test_expect_success 'ambiguity hints' '
336336
test_must_fail git rev-parse 000000000 2>stderr &&
337337
grep ^hint: stderr >hints &&
338338
# 16 candidates, plus one intro line
339339
test_line_count = 17 hints
340340
'
341341

342-
test_expect_success C_LOCALE_OUTPUT 'ambiguity hints respect type' '
342+
test_expect_success 'ambiguity hints respect type' '
343343
test_must_fail git rev-parse 000000000^{commit} 2>stderr &&
344344
grep ^hint: stderr >hints &&
345345
# 5 commits, 1 tag (which is a committish), plus intro line
346346
test_line_count = 7 hints
347347
'
348348

349-
test_expect_success C_LOCALE_OUTPUT 'failed type-selector still shows hint' '
349+
test_expect_success 'failed type-selector still shows hint' '
350350
# these two blobs share the same prefix "ee3d", but neither
351351
# will pass for a commit
352352
echo 851 | git hash-object --stdin -w &&
@@ -370,7 +370,7 @@ test_expect_success 'core.disambiguate does not override context' '
370370
git -c core.disambiguate=committish rev-parse $sha1^{tree}
371371
'
372372

373-
test_expect_success C_LOCALE_OUTPUT 'ambiguous commits are printed by type first, then hash order' '
373+
test_expect_success 'ambiguous commits are printed by type first, then hash order' '
374374
test_must_fail git rev-parse 0000 2>stderr &&
375375
grep ^hint: stderr >hints &&
376376
grep 0000 hints >objects &&

t/t3404-rebase-interactive.sh

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ test_expect_success 'verbose flag is heeded, even after --continue' '
450450
grep "^ file1 | 2 +-$" output
451451
'
452452

453-
test_expect_success C_LOCALE_OUTPUT 'multi-squash only fires up editor once' '
453+
test_expect_success 'multi-squash only fires up editor once' '
454454
base=$(git rev-parse HEAD~4) &&
455455
(
456456
set_fake_editor &&
@@ -463,7 +463,7 @@ test_expect_success C_LOCALE_OUTPUT 'multi-squash only fires up editor once' '
463463
test 1 = $(git show | grep ONCE | wc -l)
464464
'
465465

466-
test_expect_success C_LOCALE_OUTPUT 'multi-fixup does not fire up editor' '
466+
test_expect_success 'multi-fixup does not fire up editor' '
467467
git checkout -b multi-fixup E &&
468468
base=$(git rev-parse HEAD~4) &&
469469
(
@@ -514,7 +514,7 @@ test_expect_success 'commit message retained after conflict' '
514514
git branch -D conflict-squash
515515
'
516516

517-
test_expect_success C_LOCALE_OUTPUT 'squash and fixup generate correct log messages' '
517+
test_expect_success 'squash and fixup generate correct log messages' '
518518
cat >expect-squash-fixup <<-\EOF &&
519519
B
520520
@@ -541,7 +541,7 @@ test_expect_success C_LOCALE_OUTPUT 'squash and fixup generate correct log messa
541541
git branch -D squash-fixup
542542
'
543543

544-
test_expect_success C_LOCALE_OUTPUT 'squash ignores comments' '
544+
test_expect_success 'squash ignores comments' '
545545
git checkout -b skip-comments E &&
546546
base=$(git rev-parse HEAD~4) &&
547547
(
@@ -557,7 +557,7 @@ test_expect_success C_LOCALE_OUTPUT 'squash ignores comments' '
557557
git branch -D skip-comments
558558
'
559559

560-
test_expect_success C_LOCALE_OUTPUT 'squash ignores blank lines' '
560+
test_expect_success 'squash ignores blank lines' '
561561
git checkout -b skip-blank-lines E &&
562562
base=$(git rev-parse HEAD~4) &&
563563
(
@@ -995,7 +995,7 @@ test_expect_success 'rebase -ix with several instances of --exec' '
995995
test_cmp expected actual
996996
'
997997

998-
test_expect_success C_LOCALE_OUTPUT 'rebase -ix with --autosquash' '
998+
test_expect_success 'rebase -ix with --autosquash' '
999999
git reset --hard execute &&
10001000
git checkout -b autosquash &&
10011001
echo second >second.txt &&
@@ -1136,7 +1136,7 @@ test_expect_success 'rebase -i --root reword root when root has untracked file c
11361136
test "$(git rev-list --count HEAD)" = 2
11371137
'
11381138

1139-
test_expect_success C_LOCALE_OUTPUT 'rebase --edit-todo does not work on non-interactive rebase' '
1139+
test_expect_success 'rebase --edit-todo does not work on non-interactive rebase' '
11401140
git checkout reword-original-root-branch &&
11411141
git reset --hard &&
11421142
git checkout conflict-branch &&

t/t3415-rebase-autosquash.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -306,23 +306,23 @@ test_auto_fixup_fixup () {
306306
fi
307307
}
308308

309-
test_expect_success C_LOCALE_OUTPUT 'fixup! fixup!' '
309+
test_expect_success 'fixup! fixup!' '
310310
test_auto_fixup_fixup fixup fixup
311311
'
312312

313-
test_expect_success C_LOCALE_OUTPUT 'fixup! squash!' '
313+
test_expect_success 'fixup! squash!' '
314314
test_auto_fixup_fixup fixup squash
315315
'
316316

317-
test_expect_success C_LOCALE_OUTPUT 'squash! squash!' '
317+
test_expect_success 'squash! squash!' '
318318
test_auto_fixup_fixup squash squash
319319
'
320320

321-
test_expect_success C_LOCALE_OUTPUT 'squash! fixup!' '
321+
test_expect_success 'squash! fixup!' '
322322
test_auto_fixup_fixup squash fixup
323323
'
324324

325-
test_expect_success C_LOCALE_OUTPUT 'autosquash with custom inst format' '
325+
test_expect_success 'autosquash with custom inst format' '
326326
git reset --hard base &&
327327
git config --add rebase.instructionFormat "[%an @ %ar] %s" &&
328328
echo 2 >file1 &&

t/t3701-add-interactive.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ test_expect_success 'setup expected' '
370370
'
371371

372372
# Test splitting the first patch, then adding both
373-
test_expect_success C_LOCALE_OUTPUT 'add first line works' '
373+
test_expect_success 'add first line works' '
374374
git commit -am "clear local changes" &&
375375
git apply patch &&
376376
printf "%s\n" s y y | git add -p file 2>error |

t/t4012-diff-binary.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ test_expect_success 'apply --numstat understands diff --binary format' '
6363

6464
# apply needs to be able to skip the binary material correctly
6565
# in order to report the line number of a corrupt patch.
66-
test_expect_success C_LOCALE_OUTPUT 'apply detecting corrupt patch correctly' '
66+
test_expect_success 'apply detecting corrupt patch correctly' '
6767
git diff >output &&
6868
sed -e "s/-CIT/xCIT/" <output >broken &&
6969
test_must_fail git apply --stat --summary broken 2>detected &&
@@ -73,7 +73,7 @@ test_expect_success C_LOCALE_OUTPUT 'apply detecting corrupt patch correctly' '
7373
test "$detected" = xCIT
7474
'
7575

76-
test_expect_success C_LOCALE_OUTPUT 'apply detecting corrupt patch correctly' '
76+
test_expect_success 'apply detecting corrupt patch correctly' '
7777
git diff --binary | sed -e "s/-CIT/xCIT/" >broken &&
7878
test_must_fail git apply --stat --summary broken 2>detected &&
7979
detected=$(cat detected) &&

t/t4205-log-pretty-formats.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ test_expect_success 'NUL separation with --stat' '
126126
test_i18ncmp expected actual
127127
'
128128

129-
test_expect_failure C_LOCALE_OUTPUT 'NUL termination with --stat' '
129+
test_expect_failure 'NUL termination with --stat' '
130130
stat0_part=$(git diff --stat HEAD^ HEAD) &&
131131
stat1_part=$(git diff-tree --no-commit-id --stat --root HEAD^) &&
132132
printf "add bar\n$stat0_part\n\0$(commit_msg)\n$stat1_part\n0" >expected &&

t/t5300-pack-object.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ test_expect_success 'index-pack --strict <pack> works in non-repo' '
427427
test_path_is_file foo.idx
428428
'
429429

430-
test_expect_success !PTHREADS,C_LOCALE_OUTPUT 'index-pack --threads=N or pack.threads=N warns when no pthreads' '
430+
test_expect_success !PTHREADS 'index-pack --threads=N or pack.threads=N warns when no pthreads' '
431431
test_must_fail git index-pack --threads=2 2>err &&
432432
grep ^warning: err >warnings &&
433433
test_line_count = 1 warnings &&
@@ -445,7 +445,7 @@ test_expect_success !PTHREADS,C_LOCALE_OUTPUT 'index-pack --threads=N or pack.th
445445
grep -F "no threads support, ignoring pack.threads" err
446446
'
447447

448-
test_expect_success !PTHREADS,C_LOCALE_OUTPUT 'pack-objects --threads=N or pack.threads=N warns when no pthreads' '
448+
test_expect_success !PTHREADS 'pack-objects --threads=N or pack.threads=N warns when no pthreads' '
449449
git pack-objects --threads=2 --stdout --all </dev/null >/dev/null 2>err &&
450450
grep ^warning: err >warnings &&
451451
test_line_count = 1 warnings &&

0 commit comments

Comments
 (0)