plug a DIR buffer leak in rerere.c

meyering · gitster · commit a9930e359c45 · 2011-05-26T11:20:48.000-07:00
Signed-off-by: Jim Meyering &lt;jim@meyering.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/rerere.c b/rerere.c
@@ -739,6 +739,7 @@ void rerere_gc(struct string_list *rr)
 		if (then < now - cutoff * 86400)
 			string_list_append(&to_remove, e->d_name);
 	}
+	closedir(dir);
 	for (i = 0; i < to_remove.nr; i++)
 		unlink_rr_item(to_remove.items[i].string);
 	string_list_clear(&to_remove, 0);

Original file line number	Diff line number	Diff line change
`@@ -739,6 +739,7 @@ void rerere_gc(struct string_list *rr)`
`739`	`739`	`if (then < now - cutoff * 86400)`
`740`	`740`	`string_list_append(&to_remove, e->d_name);`
`741`	`741`	`}`
	`742`	`+ closedir(dir);`
`742`	`743`	`for (i = 0; i < to_remove.nr; i++)`
`743`	`744`	`unlink_rr_item(to_remove.items[i].string);`
`744`	`745`	`string_list_clear(&to_remove, 0);`