Skip to content

Commit aa8a5d1

Browse files
peffgitster
authored andcommitted
ref-filter: make parse_ref_filter_atom a private function
The parse_ref_filter_atom() function really shouldn't be exposed outside of ref-filter.c; its return value is an integer index into an array that is private in that file. Since the previous commit removed the sole external caller (and replaced it with a public function at a more appropriately level), we can just make this static. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 18a2565 commit aa8a5d1

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

ref-filter.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ struct atom_value {
364364
/*
365365
* Used to parse format string and sort specifiers
366366
*/
367-
int parse_ref_filter_atom(const char *atom, const char *ep)
367+
static int parse_ref_filter_atom(const char *atom, const char *ep)
368368
{
369369
const char *sp;
370370
const char *arg;

ref-filter.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,6 @@ struct ref_format {
104104
int filter_refs(struct ref_array *array, struct ref_filter *filter, unsigned int type);
105105
/* Clear all memory allocated to ref_array */
106106
void ref_array_clear(struct ref_array *array);
107-
/* Parse format string and sort specifiers */
108-
int parse_ref_filter_atom(const char *atom, const char *ep);
109107
/* Used to verify if the given format is correct and to parse out the used atoms */
110108
int verify_ref_format(struct ref_format *format);
111109
/* Sort the given ref_array as per the ref_sorting provided */

0 commit comments

Comments
 (0)