Skip to content

Commit aaa68dd

Browse files
Enselicgitster
authored andcommitted
git.el: Use git-add-file for unmerged files, remove git-resolve-file
Use `git-add-file' to mark unmerged files as resolved in the *git-status* buffer to be consistent with git's CLI instructions. Also remove `git-resolve-file' to make it clear that that "R" is a now a free keybinding. Signed-off-by: Martin Nordholts <[email protected]> Acked-by: Alexandre Julliard <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 3de8ba0 commit aaa68dd

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

contrib/emacs/git.el

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1046,7 +1046,7 @@ The FILES list must be sorted."
10461046
(defun git-add-file ()
10471047
"Add marked file(s) to the index cache."
10481048
(interactive)
1049-
(let ((files (git-get-filenames (git-marked-files-state 'unknown 'ignored))))
1049+
(let ((files (git-get-filenames (git-marked-files-state 'unknown 'ignored 'unmerged))))
10501050
;; FIXME: add support for directories
10511051
(unless files
10521052
(push (file-relative-name (read-file-name "File to add: " nil nil t)) files))
@@ -1119,15 +1119,6 @@ The FILES list must be sorted."
11191119
(when buffer (with-current-buffer buffer (revert-buffer t t t)))))
11201120
(git-success-message "Reverted" names))))))
11211121

1122-
(defun git-resolve-file ()
1123-
"Resolve conflicts in marked file(s)."
1124-
(interactive)
1125-
(let ((files (git-get-filenames (git-marked-files-state 'unmerged))))
1126-
(when files
1127-
(when (apply 'git-call-process-display-error "update-index" "--" files)
1128-
(git-update-status-files files)
1129-
(git-success-message "Resolved" files)))))
1130-
11311122
(defun git-remove-handled ()
11321123
"Remove handled files from the status list."
11331124
(interactive)
@@ -1556,7 +1547,6 @@ amended version of it."
15561547
(define-key map "P" 'git-prev-unmerged-file)
15571548
(define-key map "q" 'git-status-quit)
15581549
(define-key map "r" 'git-remove-file)
1559-
(define-key map "R" 'git-resolve-file)
15601550
(define-key map "t" toggle-map)
15611551
(define-key map "T" 'git-toggle-all-marks)
15621552
(define-key map "u" 'git-unmark-file)
@@ -1598,7 +1588,6 @@ amended version of it."
15981588
("Merge"
15991589
["Next Unmerged File" git-next-unmerged-file t]
16001590
["Prev Unmerged File" git-prev-unmerged-file t]
1601-
["Mark as Resolved" git-resolve-file t]
16021591
["Interactive Merge File" git-find-file-imerge t]
16031592
["Diff Against Common Base File" git-diff-file-base t]
16041593
["Diff Combined" git-diff-file-combined t]

0 commit comments

Comments
 (0)