Skip to content

Commit aab7486

Browse files
committed
Merge branch 'maint-1.6.4' into maint
* maint-1.6.4: rebase -i: more graceful handling of invalid commands help -i: properly error out if no info viewer can be found
2 parents ade2ca0 + f1be316 commit aab7486

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

builtin-help.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -372,6 +372,7 @@ static void show_info_page(const char *git_cmd)
372372
const char *page = cmd_to_page(git_cmd);
373373
setenv("INFOPATH", system_path(GIT_INFO_PATH), 1);
374374
execlp("info", "info", "gitman", page, NULL);
375+
die("no info viewer handled the request");
375376
}
376377

377378
static void get_html_page_path(struct strbuf *page_path, const char *page)

git-rebase--interactive.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,12 @@ do_next () {
408408
;;
409409
*)
410410
warn "Unknown command: $command $sha1 $rest"
411-
die_with_patch $sha1 "Please fix this in the file $TODO."
411+
if git rev-parse --verify -q "$sha1" >/dev/null
412+
then
413+
die_with_patch $sha1 "Please fix this in the file $TODO."
414+
else
415+
die "Please fix this in the file $TODO."
416+
fi
412417
;;
413418
esac
414419
test -s "$TODO" && return

0 commit comments

Comments
 (0)