Skip to content

Commit ace5e97

Browse files
Michael Palimakagitster
authored andcommitted
Explicitly set X to avoid potential build breakage
$X is appended to binary names for Windows builds (ie. git.exe). Pollution from the environment can inadvertently trigger this behaviour, resulting in 'git' turning into 'gitwhatever' without warning. Signed-off-by: Michael Palimaka <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent d0482e8 commit ace5e97

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -428,6 +428,9 @@ PROGRAM_OBJS += upload-pack.o
428428
PROGRAM_OBJS += http-backend.o
429429
PROGRAM_OBJS += sh-i18n--envsubst.o
430430

431+
# Binary suffix, set to .exe for Windows builds
432+
X =
433+
431434
PROGRAMS += $(patsubst %.o,git-%$X,$(PROGRAM_OBJS))
432435

433436
TEST_PROGRAMS_NEED_X += test-chmtime

0 commit comments

Comments
 (0)