Skip to content

Commit ad65f7e

Browse files
bwijengitster
authored andcommitted
t6026-merge-attr: child processes must not inherit index.lock handles
On Windows, a file cannot be removed unless all file handles to it have been released. Hence it is particularly important to close handles when spawning children (which would probably not even know that they hold on to those handles). The example chosen for this test is a custom merge driver that indeed has no idea that it blocks the deletion of index.lock. The full use case is a daemon that lives on after the merge, with subsequent invocations handing off to the daemon, thereby avoiding hefty start-up costs. We simulate this behavior by simply sleeping one second. Note that the test only fails on Windows, due to the file locking issue. Since we have no way to say "expect failure with MINGW, success otherwise", we simply skip this test on Windows for now. Signed-off-by: Ben Wijen <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent e0c1cea commit ad65f7e

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

t/t6026-merge-attr.sh

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,4 +181,17 @@ test_expect_success 'up-to-date merge without common ancestor' '
181181
)
182182
'
183183

184+
test_expect_success !MINGW 'custom merge does not lock index' '
185+
git reset --hard anchor &&
186+
write_script sleep-one-second.sh <<-\EOF &&
187+
sleep 1 &
188+
EOF
189+
190+
test_write_lines >.gitattributes \
191+
"* merge=ours" "text merge=sleep-one-second" &&
192+
test_config merge.ours.driver true &&
193+
test_config merge.sleep-one-second.driver ./sleep-one-second.sh &&
194+
git merge master
195+
'
196+
184197
test_done

0 commit comments

Comments
 (0)