[PATCH] Plug memory leak in git-pack-objects

sigprof · Junio C Hamano · commit adee7bdf5041 · 2005-08-08T22:51:46.000-07:00
find_deltas() should free its temporary objects before returning.

[jc: Sergey, if you have [PATCH] title on the Subject line of your
e-mail, please do not repeat it on the first line in your message
body.  Thanks.]

Signed-off-by: Sergey Vlasov &lt;vsu@altlinux.ru&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/pack-objects.c b/pack-objects.c
@@ -382,6 +382,10 @@ static void find_deltas(struct object_entry **list, int window, int depth)
 		if (idx >= window)
 			idx = 0;
 	}
+
+	for (i = 0; i < window; ++i)
+		free(array[i].data);
+	free(array);
 }
 
 int main(int argc, char **argv)

Original file line number	Diff line number	Diff line change
`@@ -382,6 +382,10 @@ static void find_deltas(struct object_entry **list, int window, int depth)`
`382`	`382`	`if (idx >= window)`
`383`	`383`	`idx = 0;`
`384`	`384`	`}`
	`385`	`+`
	`386`	`+ for (i = 0; i < window; ++i)`
	`387`	`+ free(array[i].data);`
	`388`	`+ free(array);`
`385`	`389`	`}`
`386`	`390`
`387`	`391`	`int main(int argc, char **argv)`