Skip to content

Commit ae34ac1

Browse files
johnkeepinggitster
authored andcommitted
git_remote_helpers: remove little used Python library
When it was originally added, the git_remote_helpers library was used as part of the tests of the remote-helper interface, but since commit fc407f9 (Add new simplified git-remote-testgit, 2012-11-28) a simple shell script is used for this. A search on Ohloh [1] indicates that this library isn't used by any external projects and even the Python remote helpers in contrib/ don't use this library, so it is only used by its own test suite. Since this is the only Python library in Git, removing it will make packaging easier as the Python scripts only need to be installed for one version of Python, whereas the library should be installed for all available versions. [1] http://code.ohloh.net/search?s=%22git_remote_helpers%22 Signed-off-by: John Keeping <[email protected]> Acked-by: Sverre Rabbelier <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent d2dbd39 commit ae34ac1

File tree

16 files changed

+0
-1815
lines changed

16 files changed

+0
-1815
lines changed

Makefile

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -488,11 +488,9 @@ SCRIPT_PERL += git-relink.perl
488488
SCRIPT_PERL += git-send-email.perl
489489
SCRIPT_PERL += git-svn.perl
490490

491-
SCRIPT_PYTHON += git-remote-testpy.py
492491
SCRIPT_PYTHON += git-p4.py
493492

494493
NO_INSTALL += git-remote-testgit
495-
NO_INSTALL += git-remote-testpy
496494

497495
# Generated files for scripts
498496
SCRIPT_SH_GEN = $(patsubst %.sh,%,$(SCRIPT_SH))
@@ -1669,9 +1667,6 @@ ifndef NO_TCLTK
16691667
endif
16701668
ifndef NO_PERL
16711669
$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' localedir='$(localedir_SQ)' all
1672-
endif
1673-
ifndef NO_PYTHON
1674-
$(QUIET_SUBDIR0)git_remote_helpers $(QUIET_SUBDIR1) PYTHON_PATH='$(PYTHON_PATH_SQ)' prefix='$(prefix_SQ)' all
16751670
endif
16761671
$(QUIET_SUBDIR0)templates $(QUIET_SUBDIR1) SHELL_PATH='$(SHELL_PATH_SQ)' PERL_PATH='$(PERL_PATH_SQ)'
16771672

@@ -1840,12 +1835,7 @@ ifndef NO_PYTHON
18401835
$(SCRIPT_PYTHON_GEN): GIT-CFLAGS GIT-PREFIX GIT-PYTHON-VARS
18411836
$(SCRIPT_PYTHON_GEN): % : %.py
18421837
$(QUIET_GEN)$(RM) $@ $@+ && \
1843-
INSTLIBDIR=`MAKEFLAGS= $(MAKE) -C git_remote_helpers -s \
1844-
--no-print-directory prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' \
1845-
instlibdir` && \
18461838
sed -e '1s|#!.*python|#!$(PYTHON_PATH_SQ)|' \
1847-
-e 's|\(os\.getenv("GITPYTHONLIB"\)[^)]*)|\1,"@@INSTLIBDIR@@")|' \
1848-
-e 's|@@INSTLIBDIR@@|'"$$INSTLIBDIR"'|g' \
18491839
$< >$@+ && \
18501840
chmod +x $@+ && \
18511841
mv $@+ $@
@@ -2352,9 +2342,6 @@ ifndef NO_PERL
23522342
$(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install
23532343
$(MAKE) -C gitweb install
23542344
endif
2355-
ifndef NO_PYTHON
2356-
$(MAKE) -C git_remote_helpers prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install
2357-
endif
23582345
ifndef NO_TCLTK
23592346
$(MAKE) -C gitk-git install
23602347
$(MAKE) -C git-gui gitexecdir='$(gitexec_instdir_SQ)' install
@@ -2501,9 +2488,6 @@ clean: profile-clean coverage-clean
25012488
ifndef NO_PERL
25022489
$(MAKE) -C gitweb clean
25032490
$(MAKE) -C perl clean
2504-
endif
2505-
ifndef NO_PYTHON
2506-
$(MAKE) -C git_remote_helpers clean
25072491
endif
25082492
$(MAKE) -C templates/ clean
25092493
$(MAKE) -C t/ clean

git-remote-testpy.py

Lines changed: 0 additions & 305 deletions
This file was deleted.

git_remote_helpers/.gitignore

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)