Skip to content

Commit af1e56c

Browse files
newrengitster
authored andcommitted
merge-ort: add implementation of both sides renaming identically
Implement rename/rename(1to1) handling, i.e. both sides of history renaming a file but renaming the same way. This code replaces the following from merge-recurisve.c: * all the 1to1 code in process_renames() * the RENAME_ONE_FILE_TO_ONE case of process_entry() Also, there is some shared code from merge-recursive.c for multiple different rename cases which we will no longer need for this case (or other rename cases): * handle_rename_normal() * setup_rename_conflict_info() The consolidation of four separate codepaths into one is made possible by a change in design: process_renames() tweaks the conflict_info entries within opt->priv->paths such that process_entry() can then handle all the non-rename conflict types (directory/file, modify/delete, etc.) orthogonally. This means we're much less likely to miss special implementation of some kind of combination of conflict types (see commits brought in by 66c62ea ("Merge branch 'en/merge-tests'", 2020-11-18), especially commit ef52778 ("merge tests: expect improved directory/file conflict handling in ort", 2020-10-26) for more details). That, together with letting worktree/index updating be handled orthogonally in the merge_switch_to_result() function, dramatically simplifies the code for various special rename cases. Signed-off-by: Elijah Newren <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent c2d267d commit af1e56c

File tree

1 file changed

+18
-2
lines changed

1 file changed

+18
-2
lines changed

merge-ort.c

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -674,14 +674,30 @@ static int process_renames(struct merge_options *opt,
674674
!strcmp(oldpath, renames->queue[i+1]->one->path)) {
675675
/* Handle rename/rename(1to2) or rename/rename(1to1) */
676676
const char *pathnames[3];
677+
struct version_info merged;
678+
struct conflict_info *base, *side1, *side2;
677679

678680
pathnames[0] = oldpath;
679681
pathnames[1] = newpath;
680682
pathnames[2] = renames->queue[i+1]->two->path;
681683

684+
base = strmap_get(&opt->priv->paths, pathnames[0]);
685+
side1 = strmap_get(&opt->priv->paths, pathnames[1]);
686+
side2 = strmap_get(&opt->priv->paths, pathnames[2]);
687+
688+
VERIFY_CI(base);
689+
VERIFY_CI(side1);
690+
VERIFY_CI(side2);
691+
682692
if (!strcmp(pathnames[1], pathnames[2])) {
683-
/* Both sides renamed the same way. */
684-
die("Not yet implemented");
693+
/* Both sides renamed the same way */
694+
assert(side1 == side2);
695+
memcpy(&side1->stages[0], &base->stages[0],
696+
sizeof(merged));
697+
side1->filemask |= (1 << MERGE_BASE);
698+
/* Mark base as resolved by removal */
699+
base->merged.is_null = 1;
700+
base->merged.clean = 1;
685701

686702
/* We handled both renames, i.e. i+1 handled */
687703
i++;

0 commit comments

Comments
 (0)