Skip to content

Commit b0db798

Browse files
committed
t6120: further modernize
There is absolutely no reason why a pattern given to grep to find 'warning: --stdin is deprecated' must be quoted within a pair of single quotes, or the pattern to look for the literal string as ERE. Quote the test body with a pair of single quotes like everybody else, and quote the needle string in a pair of double quotes. Also use test_grep instead of "grep -E". Signed-off-by: Junio C Hamano <[email protected]>
1 parent a733ec8 commit b0db798

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

t/t6120-describe.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -298,11 +298,11 @@ test_expect_success 'name-rev --annotate-stdin' '
298298
test_cmp expect actual
299299
'
300300

301-
test_expect_success 'name-rev --stdin deprecated' "
301+
test_expect_success 'name-rev --stdin deprecated' '
302302
git rev-list --all >list &&
303303
git name-rev --stdin <list 2>actual &&
304-
grep -E 'warning: --stdin is deprecated' actual
305-
"
304+
test_grep "warning: --stdin is deprecated" actual
305+
'
306306

307307
test_expect_success 'describe --contains with the exact tags' '
308308
echo "A^0" >expect &&

0 commit comments

Comments
 (0)