Skip to content

Commit b0eab01

Browse files
committed
branch -m/-M: remove undocumented RENAMED-REF
The commit message for c976d41 (git-branch: add options and tests for branch renaming, 2006-11-28) mentions RENAME_REF but otherwise this is not documented anywhere, and it does not appear in any of the tests. Worse yet, the name of the actual file is "RENAMED-REF". This was supposed to hold the commit object name at the tip of the branch the most recent "branch -m/-M" renamed, but that is not necessary in order to be able to recover from a mistake. Even when "branch -M A B" overwrites an existing branch B, what is kept in RENAMED-REF is the commit at the tip of the original branch A, not the commit B from the now-lost branch. Just remove this unused "feature". Signed-off-by: Junio C Hamano <[email protected]>
1 parent c976d41 commit b0eab01

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

refs.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -786,7 +786,6 @@ int delete_ref(const char *refname, unsigned char *sha1)
786786

787787
int rename_ref(const char *oldref, const char *newref)
788788
{
789-
static const char renamed_ref[] = "RENAMED-REF";
790789
unsigned char sha1[20], orig_sha1[20];
791790
int flag = 0, logmoved = 0;
792791
struct ref_lock *lock;
@@ -809,13 +808,6 @@ int rename_ref(const char *oldref, const char *newref)
809808
if (snprintf(msg, sizeof(msg), "renamed %s to %s", oldref, newref) > sizeof(msg))
810809
return error("Refnames to long");
811810

812-
lock = lock_ref_sha1_basic(renamed_ref, NULL, NULL);
813-
if (!lock)
814-
return error("unable to lock %s", renamed_ref);
815-
lock->force_write = 1;
816-
if (write_ref_sha1(lock, orig_sha1, msg))
817-
return error("unable to save current sha1 in %s", renamed_ref);
818-
819811
if (log && rename(git_path("logs/%s", oldref), git_path("tmp-renamed-log")))
820812
return error("unable to move logfile logs/%s to tmp-renamed-log: %s",
821813
oldref, strerror(errno));

0 commit comments

Comments
 (0)