Skip to content

Commit b1c2edf

Browse files
bmwillgitster
authored andcommitted
transport-helper: remove name parameter
Commit 266f1fd (transport-helper: be quiet on read errors from helpers, 2013-06-21) removed a call to 'die()' which printed the name of the remote helper passed in to the 'recvline_fh()' function using the 'name' parameter. Once the call to 'die()' was removed the parameter was no longer necessary but wasn't removed. Clean up 'recvline_fh()' parameter list by removing the 'name' parameter. Signed-off-by: Brandon Williams <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 1aa8dde commit b1c2edf

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

transport-helper.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ static void sendline(struct helper_data *helper, struct strbuf *buffer)
4949
die_errno("Full write to remote helper failed");
5050
}
5151

52-
static int recvline_fh(FILE *helper, struct strbuf *buffer, const char *name)
52+
static int recvline_fh(FILE *helper, struct strbuf *buffer)
5353
{
5454
strbuf_reset(buffer);
5555
if (debug)
@@ -67,7 +67,7 @@ static int recvline_fh(FILE *helper, struct strbuf *buffer, const char *name)
6767

6868
static int recvline(struct helper_data *helper, struct strbuf *buffer)
6969
{
70-
return recvline_fh(helper->out, buffer, helper->name);
70+
return recvline_fh(helper->out, buffer);
7171
}
7272

7373
static void write_constant(int fd, const char *str)
@@ -586,7 +586,7 @@ static int process_connect_service(struct transport *transport,
586586
goto exit;
587587

588588
sendline(data, &cmdbuf);
589-
if (recvline_fh(input, &cmdbuf, name))
589+
if (recvline_fh(input, &cmdbuf))
590590
exit(128);
591591

592592
if (!strcmp(cmdbuf.buf, "")) {

0 commit comments

Comments
 (0)