Skip to content

Commit b1d5e20

Browse files
nalladscho
authored andcommitted
mingw: explicitly fflush stdout
For performance reasons `stdout` is not unbuffered by default. That leads to problems if after printing to `stdout` a read on `stdin` is performed. For that reason interactive commands like `git clean -i` do not function properly anymore if the `stdout` is not flushed by `fflush(stdout)` before trying to read from `stdin`. In the case of `git clean -i` all reads on `stdin` were preceded by a `fflush(stdout)` call. Signed-off-by: nalla <[email protected]>
1 parent 99a104d commit b1d5e20

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

builtin/clean.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -595,6 +595,7 @@ static int *list_and_choose(struct menu_opts *opts, struct menu_stuff *stuff)
595595
clean_get_color(CLEAN_COLOR_RESET));
596596
}
597597

598+
fflush(stdout);
598599
if (strbuf_getline_lf(&choice, stdin) != EOF) {
599600
strbuf_trim(&choice);
600601
} else {
@@ -677,6 +678,7 @@ static int filter_by_patterns_cmd(void)
677678
clean_print_color(CLEAN_COLOR_PROMPT);
678679
printf(_("Input ignore patterns>> "));
679680
clean_print_color(CLEAN_COLOR_RESET);
681+
fflush(stdout);
680682
if (strbuf_getline_lf(&confirm, stdin) != EOF)
681683
strbuf_trim(&confirm);
682684
else
@@ -775,6 +777,7 @@ static int ask_each_cmd(void)
775777
qname = quote_path_relative(item->string, NULL, &buf);
776778
/* TRANSLATORS: Make sure to keep [y/N] as is */
777779
printf(_("Remove %s [y/N]? "), qname);
780+
fflush(stdout);
778781
if (strbuf_getline_lf(&confirm, stdin) != EOF) {
779782
strbuf_trim(&confirm);
780783
} else {

0 commit comments

Comments
 (0)