Skip to content

Commit b202514

Browse files
committed
http.c: avoid freeing an uninitialized pointer
An earlier 59b8d38 (http.c: remove verification of remote packs) left the variable "url" uninitialized; "goto cleanup" codepath can free it which is not very nice. Signed-off-by: Junio C Hamano <[email protected]>
1 parent 59b8d38 commit b202514

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

http.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -866,7 +866,7 @@ static int fetch_pack_index(unsigned char *sha1, const char *base_url)
866866
int ret = 0;
867867
char *hex = xstrdup(sha1_to_hex(sha1));
868868
char *filename;
869-
char *url;
869+
char *url = NULL;
870870
struct strbuf buf = STRBUF_INIT;
871871

872872
if (has_pack_index(sha1)) {

0 commit comments

Comments
 (0)