Skip to content

Commit b2a8226

Browse files
mhaggergitster
authored andcommitted
pack_one_ref(): do some cheap tests before a more expensive one
Signed-off-by: Michael Haggerty <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 0f29920 commit b2a8226

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

refs.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2008,18 +2008,17 @@ static int pack_one_ref(struct ref_entry *entry, void *cb_data)
20082008
{
20092009
struct pack_refs_cb_data *cb = cb_data;
20102010
enum peel_status peel_status;
2011-
int is_tag_ref;
2012-
2013-
/* Do not pack symbolic or broken refs: */
2014-
if ((entry->flag & REF_ISSYMREF) || !ref_resolves_to_object(entry))
2015-
return 0;
2016-
is_tag_ref = !prefixcmp(entry->name, "refs/tags/");
2011+
int is_tag_ref = !prefixcmp(entry->name, "refs/tags/");
20172012

20182013
/* ALWAYS pack refs that were already packed or are tags */
20192014
if (!(cb->flags & PACK_REFS_ALL) && !is_tag_ref &&
20202015
!(entry->flag & REF_ISPACKED))
20212016
return 0;
20222017

2018+
/* Do not pack symbolic or broken refs: */
2019+
if ((entry->flag & REF_ISSYMREF) || !ref_resolves_to_object(entry))
2020+
return 0;
2021+
20232022
peel_status = peel_entry(entry, 1);
20242023
if (peel_status != PEEL_PEELED && peel_status != PEEL_NON_TAG)
20252024
die("internal error peeling reference %s (%s)",

0 commit comments

Comments
 (0)