Skip to content

Commit b3bb5f7

Browse files
peffgitster
authored andcommitted
cvsimport: always pass user data to "system" as a list
This avoids invoking the shell. Not only is it faster, but it prevents the possibility of interpreting our arguments in the shell. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 861f00e commit b3bb5f7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

git-cvsimport.perl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -767,7 +767,7 @@ sub commit {
767767
waitpid($pid,0);
768768
die "Error running git-commit-tree: $?\n" if $?;
769769

770-
system("git-update-ref $remote/$branch $cid") == 0
770+
system('git-update-ref', "$remote/$branch", $cid) == 0
771771
or die "Cannot write branch $branch for update: $!\n";
772772

773773
if ($tag) {

0 commit comments

Comments
 (0)