Skip to content

Commit b42c9af

Browse files
drafnelgitster
authored andcommitted
Makefile: remove pointless conditional assignment in SunOS section
It is true that NEEDS_RESOLV is needed on SunOS if NO_IPV6 is set since hstrerror() resides in libresolv, but performing this test at its current location is not very useful. It will only have any effect if the user modifies the make variables from the make command line, and will have no effect if a config.mak file is used. A better location for this conditional would have been further down in the Makefile after the config.mak and config.mak.autogen had been parsed. Rather than adding clutter to the Makefile for a conditional that will likely never be triggered, just remove it, and any user on SunOS that manually sets NO_IPV6 can also set NEEDS_RESOLV. Signed-off-by: Brandon Casey <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 68ea474 commit b42c9af

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

Makefile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -757,9 +757,6 @@ ifeq ($(uname_S),SunOS)
757757
NO_C99_FORMAT = YesPlease
758758
NO_STRTOUMAX = YesPlease
759759
endif
760-
ifdef NO_IPV6
761-
NEEDS_RESOLV = YesPlease
762-
endif
763760
INSTALL = /usr/ucb/install
764761
TAR = gtar
765762
BASIC_CFLAGS += -D__EXTENSIONS__ -D__sun__ -DHAVE_ALLOCA_H

0 commit comments

Comments
 (0)