Skip to content

Commit b6a259c

Browse files
kbleesdscho
authored andcommitted
Win32: lstat(): return adequate stat.st_size for symlinks
Git typically doesn't trust the stat.st_size member of symlinks (e.g. see strbuf_readlink()). However, some functions take shortcuts if st_size is 0 (e.g. diff_populate_filespec()). In mingw_lstat() and fscache_lstat(), make sure to return an adequate size. The extra overhead of opening and reading the reparse point to calculate the exact size is not necessary, as git doesn't rely on the value anyway. Signed-off-by: Karsten Blees <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 6ed80b8 commit b6a259c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

compat/mingw.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -895,8 +895,8 @@ int mingw_lstat(const char *file_name, struct stat *buf)
895895
buf->st_nlink = 1;
896896
buf->st_mode = file_attr_to_st_mode(fdata.dwFileAttributes,
897897
findbuf.dwReserved0);
898-
buf->st_size = fdata.nFileSizeLow |
899-
(((off_t)fdata.nFileSizeHigh)<<32);
898+
buf->st_size = S_ISLNK(buf->st_mode) ? MAX_LONG_PATH :
899+
fdata.nFileSizeLow | (((off_t) fdata.nFileSizeHigh) << 32);
900900
buf->st_dev = buf->st_rdev = 0; /* not used by Git */
901901
filetime_to_timespec(&(fdata.ftLastAccessTime), &(buf->st_atim));
902902
filetime_to_timespec(&(fdata.ftLastWriteTime), &(buf->st_mtim));

0 commit comments

Comments
 (0)