Skip to content

Commit b79966a

Browse files
phillipwoodgitster
authored andcommitted
rebase -p: error out if --signoff is given
rebase --preserve-merges does not support --signoff so error out rather than just silently ignoring it so that the user knows the commits will not be signed off. Signed-off-by: Phillip Wood <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent a852ec7 commit b79966a

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

git-rebase.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -472,6 +472,8 @@ fi
472472

473473
if test -n "$signoff"
474474
then
475+
test -n "$preserve_merges" &&
476+
die "$(gettext "error: cannot combine '--signoff' with '--preserve-merges'")"
475477
git_am_opt="$git_am_opt $signoff"
476478
force_rebase=t
477479
fi

0 commit comments

Comments
 (0)