Skip to content

Commit b7df098

Browse files
stefanbellergitster
authored andcommitted
log, format-patch: parsing uses OPT__QUIET
This patch allows users to use the short form -q on log and format-patch, which was non possible before. Also the documentation of format-patch mentions -q now. The documentation of log doesn't even talk about --quiet, so I'll leave that for more experienced git contributors. ;) It doesn't seem to change the default behavior, but in combination with --stat for example it suppresses the actual stats. however the only relevant code in log is if (quiet) rev->diffopt.output_format |= DIFF_FORMAT_NO_OUTPUT; Signed-off-by: Stefan Beller <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent d5d09d4 commit b7df098

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Documentation/git-format-patch.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ configuration options in linkgit:git-notes[1] to use this workflow).
242242
Note that the leading character does not have to be a dot; for example,
243243
you can use `--suffix=-patch` to get `0001-description-of-my-change-patch`.
244244

245+
-q::
245246
--quiet::
246247
Do not print the names of the generated files to standard output.
247248

builtin/log.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ static void cmd_log_init_finish(int argc, const char **argv, const char *prefix,
121121
static struct line_opt_callback_data line_cb = {NULL, NULL, STRING_LIST_INIT_DUP};
122122

123123
const struct option builtin_log_options[] = {
124-
OPT_BOOL(0, "quiet", &quiet, N_("suppress diff output")),
124+
OPT__QUIET(&quiet, N_("suppress diff output")),
125125
OPT_BOOL(0, "source", &source, N_("show source")),
126126
OPT_BOOL(0, "use-mailmap", &mailmap, N_("Use mail map file")),
127127
{ OPTION_CALLBACK, 0, "decorate", NULL, NULL, N_("decorate options"),
@@ -1210,8 +1210,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
12101210
PARSE_OPT_OPTARG, thread_callback },
12111211
OPT_STRING(0, "signature", &signature, N_("signature"),
12121212
N_("add a signature")),
1213-
OPT_BOOLEAN(0, "quiet", &quiet,
1214-
N_("don't print the patch filenames")),
1213+
OPT__QUIET(&quiet, N_("don't print the patch filenames")),
12151214
OPT_END()
12161215
};
12171216

0 commit comments

Comments
 (0)