Skip to content

Commit b7e642e

Browse files
committed
request-pull: use the real fork point when preparing the message
The command takes the "start" argument and computes the merge base between it and the commit to be pulled so that we can show the diffstat, but uses the "start" argument as-is when composing the message The following changes since commit $X are available to tell the integrator which commit the work is based on. Giving "origin" (most of the time it resolves to refs/remotes/origin/master) as the start argument is often convenient, but it is usually not the fork point, and does not help the integrator at all. Use the real fork point, which is the merge base we already compute, when composing that part of the message. Suggested-by: Linus Torvalds Signed-off-by: Junio C Hamano <[email protected]>
1 parent f032d66 commit b7e642e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

git-request-pull.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ git show -s --format='The following changes since commit %H:
9696
%s (%ci)
9797
9898
are available in the git repository at:
99-
' $baserev &&
99+
' $merge_base &&
100100
echo " $url${ref+ $ref}" &&
101101
git show -s --format='
102102
for you to fetch changes up to %H:

0 commit comments

Comments
 (0)