Skip to content

Commit b89c731

Browse files
jonathantanmygitster
authored andcommitted
t5601: mark protocol v2-only test
A HTTP-clone test introduced in 4fe788b ("builtin/clone.c: add --reject-shallow option", 2021-04-01) only works in protocol v2, but is not marked as such. The aforementioned patch implements --reject-shallow for a variety of situations, but usage of a protocol that requires a remote helper is not one of them. (Such an implementation would require extending the remote helper protocol to support the passing of a "reject shallow" option, and then teaching it to both protocol-speaking ends.) For now, to make it pass when GIT_TEST_PROTOCOL_VERSION=0 is passed, add "-c protocol.version=2". A more complete solution would be either to augment the remote helper protocol to support this feature or to return a fatal error when using --reject-shallow with a protocol that uses a remote helper. Signed-off-by: Jonathan Tan <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 4fe788b commit b89c731

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/t5601-clone.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,7 @@ test_expect_success 'partial clone using HTTP' '
762762
test_expect_success 'reject cloning shallow repository using HTTP' '
763763
test_when_finished "rm -rf repo" &&
764764
git clone --bare --no-local --depth=1 src "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
765-
test_must_fail git clone --reject-shallow $HTTPD_URL/smart/repo.git repo 2>err &&
765+
test_must_fail git -c protocol.version=2 clone --reject-shallow $HTTPD_URL/smart/repo.git repo 2>err &&
766766
test_i18ngrep -e "source repository is shallow, reject to clone." err &&
767767
768768
git clone --no-reject-shallow $HTTPD_URL/smart/repo.git repo

0 commit comments

Comments
 (0)