push: Correctly initialize nonfastforward in transport_push.

moy · gitster · commit bb8cccd01762 · 2009-09-20T12:11:29.000-07:00
The variable is assigned unconditionally in print_push_status, but
print_push_status is not reached by all codepaths. In particular, this
fixes a bug where "git push ... nonexisting-branch" was complaining about
non-fast forward.

Signed-off-by: Matthieu Moy &lt;Matthieu.Moy@imag.fr&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/transport.c b/transport.c
@@ -1001,8 +1001,9 @@ int transport_set_option(struct transport *transport,
 
 int transport_push(struct transport *transport,
 		   int refspec_nr, const char **refspec, int flags,
-		   int * nonfastforward)
+		   int *nonfastforward)
 {
+	*nonfastforward = 0;
 	verify_remote_names(refspec_nr, refspec);
 
 	if (transport->push)

Original file line number	Diff line number	Diff line change
`@@ -1001,8 +1001,9 @@ int transport_set_option(struct transport *transport,`
`1001`	`1001`
`1002`	`1002`	`int transport_push(struct transport *transport,`
`1003`	`1003`	`int refspec_nr, const char **refspec, int flags,`
`1004`		`- int * nonfastforward)`
	`1004`	`+ int *nonfastforward)`
`1005`	`1005`	`{`
	`1006`	`+ *nonfastforward = 0;`
`1006`	`1007`	`verify_remote_names(refspec_nr, refspec);`
`1007`	`1008`
`1008`	`1009`	`if (transport->push)`